HOTFIX re-introduce indeterminate result for checkPredicates instead of exceptions
#3908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on inconsistent ground truth
jberthold
commented
May 30, 2024
| @@ -263,9 +263,9 @@ checkPredicates :: | |||
| Set Predicate -> | |||
| Map Variable Term -> | |||
| Set Predicate -> | |||
| io (Either SMTError Bool) | |||
| io (Either SMTError (Maybe Bool)) | |||
There was a problem hiding this comment.
Since the SMTSolverUnknown is not a "real error", we could also use a 4-fold dedicated result type here
data CheckPredicatesResult
= PredicatesTrue
| PredicatesFalse
| PredicatesIndeterminate
| UnknownResult
That means we can throw exceptions directly from here as we did before.
The current version puts the burden on the caller but leaves more flexibility.
geo2a
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMTSolverUnknownwhen checking requires clauses, but throws actual exceptions (terminating the request) on other SMT errors (translation error, general error).Follow-up to #3907