Add count-aborts binary
#3911
Merged
Add count-aborts binary
#3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a single tree by nesting contexts
geo2a
reviewed
Jun 3, 2024
geo2a
reviewed
Jun 3, 2024
There was a problem hiding this comment.
The code looks good to me! I would like to see more comments and a --help description of what the commands are supposed to de. Also, I understand that @jberthold is working on a similar solution as well. We need to sync in the daily to coordinate.
…enough to be useful
geo2a
approved these changes
Jun 3, 2024
goodlyrottenapple
added a commit
that referenced
this pull request
Jun 4, 2024
More tweaks and cleanup of the contextual logs including: * Remove monad logger from booster code fully and add an "always show" flag to simulate info logs that should be always used no matter the context filter (use sparingly!!). the flag is set when logging via `logMessage'` (perhaps need a different name?). Fixes #3867 * Switch abort analysis to using the JSON context logs. This includes translating the required context filters into the previously used `-l Abort` log level, as well as using the new `count-aborts` (#3911) utility. Fixes #3865 * Introduce new `failure,break` and `failure,continue` nested contexts, which are emitted based on whether we are evaluating functions or simplifications. * Improve ceil analysis contextual logs --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
count-abortsbinary which can count aborts viacount-aborts file_1 ... file_n, producing a simple table of the form:The files expected as input to this tool are produced by the booster via
--log-format json --log-file <file>.