Remove cabal cache form CI #3932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
requested review from
geo2a and
jberthold
and removed request for
geo2a
jberthold
approved these changes
Jun 11, 2024
Comment on lines
+10
to
+13
| env: | ||
| ghc_version: "9.6.5" | ||
| stack_version: "2.15.1" | ||
| hpack_version: '0.36' |
There was a problem hiding this comment.
(nit) could remove those variables from release.yml to avoid confusion
There was a problem hiding this comment.
good idea
geo2a
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that we are trying to cache the cabal store, however, Nix already does this for us, as we have seen from the fact that cache has been broken but builds run just as fast. Therefore, this caching should be removed entirely.
This also fixes an issue where the cache key on master was not being built correctly, because we forgot to set the
ghc_versionENV variable. THis also meant we were building with a different version of GHC on master push vs the feature branches.