Skip to content

Remove directory name assumption in kore-rpc-client #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2024
Merged

Remove directory name assumption in kore-rpc-client #3970

merged 3 commits into from
Jul 10, 2024

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Jul 9, 2024 •
edited
Loading

  • when running a tarball, consider the requests from all directories, not just the one prefixed with rpc_
  • allow creating parent directories when unpacking a tarball

@geo2a geo2a force-pushed the georgy/kore-rpc-client-modification branch from e397bff to 5a916ae Compare July 9, 2024 13:15
@geo2a geo2a marked this pull request as ready for review July 9, 2024 13:17
@geo2a geo2a requested a review from jberthold July 9, 2024 13:17
jberthold
jberthold approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The next change is already around the corner... runtimeverification/k#4509

@jberthold jberthold merged commit 0932411 into master Jul 10, 2024
6 checks passed
@jberthold jberthold deleted the georgy/kore-rpc-client-modification branch July 10, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberthold jberthold jberthold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geo2a @jberthold