Skip to content

Increase depth and emit a trace when pruning vacuous branches in Proxy.hs #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Jul 11, 2024

Fixes #3973

@geo2a geo2a force-pushed the georgy/fix-proxy branch from 882113e to 2cef1b6 Compare July 11, 2024 12:28
@geo2a
Copy link
Contributor Author

geo2a commented Jul 11, 2024

No difference in KEVM performance:

| Test                                        | georgy-fix-proxy time | master-0932411b9 time | (georgy-fix-proxy/master-0932411b9) time
|---------------------------------------------|-----------------------|-----------------------|------------------------------------------
| mcd/flopper-dent-guy-same-pass-rough-spec.k | 862.93                | 804.53                | 1.072588964985768
| TOTAL                                       | 862.93                | 804.53                | 1.072588964985768

@geo2a geo2a marked this pull request as ready for review July 11, 2024 15:34
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@geo2a geo2a merged commit 95d7d59 into master Jul 12, 2024
6 checks passed
@geo2a geo2a deleted the georgy/fix-proxy branch July 12, 2024 06:13
geo2a added a commit that referenced this pull request Jul 12, 2024
rv-jenkins added a commit to runtimeverification/k that referenced this pull request Jul 13, 2024
With runtimeverification/haskell-backend#3974,
`kore-rpc-booster` increments execution depth and emits a rewrite trace
in the scenario of pruning all but one branches in a branching execute
response. The trace has origin `"proxy"`, because that's where the step
is effectively taken. This PR makes sure `pyk` is ready to handle this.

Co-authored-by: rv-jenkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy.hs loses information when pruning branches
2 participants