Skip to content

Add [request id] context to relevant proxy log entries #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Jul 11, 2024

Most [proxy] log entries are prefixed with [request ID]. The exception are are entries that are emitted in-between requests.

Before:

[proxy] Starting RPC server
[proxy] Processing request 0
[proxy] Starting execute request
[request 0][booster][execute][depth] 0 steps.
...
[proxy] Booster Aborted at Depth {getNat = 0}
[proxy] Simplifying booster state and falling back to Kore
[proxy] Simplifying execution state
...

After:

[proxy] Starting RPC server
[proxy] Processing request 0
[request 0][proxy] Starting execute request
[request 0][booster][execute][depth] 0 steps.
...
[request 0][proxy] Booster Aborted at Depth {getNat = 0}
[request 0][proxy] Simplifying booster state and falling back to Kore
[request 0][proxy] Simplifying execution state
...

@geo2a geo2a marked this pull request as ready for review July 11, 2024 15:52
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Only question is, are we now getting duplicated request <N> entries for the sections where koreRespond is working on the request?

@geo2a
Copy link
Contributor Author

geo2a commented Jul 12, 2024

@jberthold I though we would, and removed the code that adds tre request id in Kore, but got the output with no request id for Kore 🙅 I think something in the logger setup requires us to explicitly add them in Kore.

@geo2a geo2a merged commit 561a538 into master Jul 12, 2024
6 checks passed
@geo2a geo2a deleted the proxy-log-request-id branch July 12, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants