Add pyk implication tests to the rpc integration test suite #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
approved these changes
Jul 29, 2024
| @@ -0,0 +1,2685 @@ | |||
| [topCellInitializer{}(LblinitGeneratedTopCell{}()), org'Stop'kframework'Stop'attributes'Stop'Source{}("Source(/private/tmp/pytest-of-sam/pytest-8/popen-gw1/kompiled0/k-files/definition-1.k)")] | |||
There was a problem hiding this comment.
Maybe we should check in the original K file for this.
Ditto for implies2.{k,kore}
There was a problem hiding this comment.
These are generated via pyk, so not sure how to go about extracting a K definition
booster/test/rpc-integration/test-implies2/response-consequent-constraint.booster-dev
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| {"jsonrpc": "2.0", "id": "4428382960-001", "method": "implies", "params": {"antecedent": {"format": "KORE", "version": 1, "term": {"tag": "And", "sort": {"tag": "SortApp", "name": "SortGeneratedTopCell", "args": []}, "patterns": [{"tag": "App", "name": "Lbl'-LT-'generatedTop'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'-LT-'T'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'-LT-'k'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "kseq", "sorts": [], "args": [{"tag": "App", "name": "inj", "sorts": [{"tag": "SortApp", "name": "SortPgm", "args": []}, {"tag": "SortApp", "name": "SortKItem", "args": []}], "args": [{"tag": "App", "name": "Lblint'UndsSClnUnds'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'UndsCommUnds'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortId", "args": []}, "value": "$n"}, {"tag": "App", "name": "Lbl'UndsCommUnds'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortId", "args": []}, "value": "$s"}, {"tag": "App", "name": "Lbl'Stop'List'LBraQuotUndsCommUndsQuotRBra'", "sorts": [], "args": []}]}]}, {"tag": "App", "name": "Lbl'UndsEqlsUndsSCln'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortId", "args": []}, "value": "$n"}, {"tag": "App", "name": "inj", "sorts": [{"tag": "SortApp", "name": "SortInt", "args": []}, {"tag": "SortApp", "name": "SortAExp", "args": []}], "args": [{"tag": "EVar", "name": "VarX", "sort": {"tag": "SortApp", "name": "SortInt", "args": []}}]}]}]}]}, {"tag": "App", "name": "dotk", "sorts": [], "args": []}]}]}, {"tag": "App", "name": "Lbl'-LT-'state'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'Stop'Map", "sorts": [], "args": []}]}]}, {"tag": "EVar", "name": "VarGENERATED'Unds'COUNTER'Unds'CELL", "sort": {"tag": "SortApp", "name": "SortGeneratedCounterCell", "args": []}}]}, {"tag": "And", "sort": {"tag": "SortApp", "name": "SortGeneratedTopCell", "args": []}, "patterns": [{"tag": "Equals", "argSort": {"tag": "SortApp", "name": "SortBool", "args": []}, "sort": {"tag": "SortApp", "name": "SortGeneratedTopCell", "args": []}, "first": {"tag": "DV", "sort": {"tag": "SortApp", "name": "SortBool", "args": []}, "value": "true"}, "second": {"tag": "App", "name": "Lbl'Unds-LT-'Int'Unds'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortInt", "args": []}, "value": "3"}, {"tag": "EVar", "name": "VarX", "sort": {"tag": "SortApp", "name": "SortInt", "args": []}}]}}, {"tag": "Equals", "argSort": {"tag": "SortApp", "name": "SortBool", "args": []}, "sort": {"tag": "SortApp", "name": "SortGeneratedTopCell", "args": []}, "first": {"tag": "DV", "sort": {"tag": "SortApp", "name": "SortBool", "args": []}, "value": "true"}, "second": {"tag": "App", "name": "Lbl'Unds-LT-'Int'Unds'", "sorts": [], "args": [{"tag": "EVar", "name": "VarX", "sort": {"tag": "SortApp", "name": "SortInt", "args": []}}, {"tag": "DV", "sort": {"tag": "SortApp", "name": "SortInt", "args": []}, "value": "3"}]}}]}]}}, "consequent": {"format": "KORE", "version": 1, "term": {"tag": "Exists", "sort": {"tag": "SortApp", "name": "SortGeneratedTopCell", "args": []}, "var": "VarY", "varSort": {"tag": "SortApp", "name": "SortAExp", "args": []}, "arg": {"tag": "App", "name": "Lbl'-LT-'generatedTop'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'-LT-'T'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'-LT-'k'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "kseq", "sorts": [], "args": [{"tag": "App", "name": "inj", "sorts": [{"tag": "SortApp", "name": "SortPgm", "args": []}, {"tag": "SortApp", "name": "SortKItem", "args": []}], "args": [{"tag": "App", "name": "Lblint'UndsSClnUnds'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'UndsCommUnds'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortId", "args": []}, "value": "$n"}, {"tag": "App", "name": "Lbl'UndsCommUnds'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortId", "args": []}, "value": "$s"}, {"tag": "App", "name": "Lbl'Stop'List'LBraQuotUndsCommUndsQuotRBra'", "sorts": [], "args": []}]}]}, {"tag": "App", "name": "Lbl'UndsEqlsUndsSCln'", "sorts": [], "args": [{"tag": "DV", "sort": {"tag": "SortApp", "name": "SortId", "args": []}, "value": "$n"}, {"tag": "EVar", "name": "VarY", "sort": {"tag": "SortApp", "name": "SortAExp", "args": []}}]}]}]}, {"tag": "App", "name": "dotk", "sorts": [], "args": []}]}]}, {"tag": "App", "name": "Lbl'-LT-'state'-GT-'", "sorts": [], "args": [{"tag": "App", "name": "Lbl'Stop'Map", "sorts": [], "args": []}]}]}, {"tag": "EVar", "name": "VarGENERATED'Unds'COUNTER'Unds'CELL", "sort": {"tag": "SortApp", "name": "SortGeneratedCounterCell", "args": []}}]}}}}} | |||
There was a problem hiding this comment.
This is quite hard to read, maybe we should check in pretty-printed json?
Or, better, add a README.md file to the directory that contains a short description of what the data is?
For instance, this one here is not an obvious Bottom in the antecedent, what makes it Bottom is X =Int 3 and X <Int 3 in the constraints.
…ation/haskell-backend into sam/implication-rpc-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in bringing the booster implication endpoint in line with kore. Most of the
.booster-devresponses will eventually be the same/equivalent to the kore responses.