Skip to content

remove SMT solver from RewriteStepState, use solver from arg. to evaluate #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jberthold
Copy link
Member

@jberthold jberthold commented Jul 29, 2024

Supplies the SMT solver from the performRewrite instead of a (wrong) value from RewriteStepState.
We don't need the SMT solver in the RewriteStepState as it won't be modified, and the old code was also setting it to Nothing.

@jberthold jberthold changed the title remove smt solver from RewriteStepState, use correct solver to evaluate remove SMT solver from RewriteStepState, use solver from arg. to evaluate Jul 29, 2024
@jberthold
Copy link
Member Author

Test HOTFIX-actually-use-smt-solver-for-equations time master-613cb4984 time (HOTFIX-actually-use-smt-solver-for-equations/master-613cb4984) time
benchmarks/ecrecoverloop02-sigs-valid-spec.k 85.65 190.76 0.4489934996854687
benchmarks/ecrecoverloop02-sig1-invalid-spec.k 85.63 187.36 0.4570345858240819
benchmarks/ecrecoverloop02-sig0-invalid-spec.k 66.5 112.22 0.5925859918018178
mcd/end-cash-pass-rough-spec.k 154.24 224.16 0.6880799428979301
erc20/ds/transferFrom-success-1-spec.k 53.48 64.6 0.8278637770897833
erc20/ds/transferFrom-success-2-spec.k 50.62 59.89 0.8452162297545499
erc20/ds/transfer-success-1-spec.k 46.18 53.6 0.8615671641791044
erc20/ds/transfer-success-2-spec.k 46.02 52.8 0.8715909090909092
mcd/flapper-yank-pass-rough-spec.k 136.89 154.85 0.8840167904423635
mcd/flopper-cage-pass-spec.k 40.1 44.9 0.8930957683741648
mcd/end-pack-pass-rough-spec.k 115.25 128.31 0.8982152599173876
erc20/hkg/transferFrom-success-1-spec.k 47.87 51.66 0.9266356949283778
erc20/ds/transfer-failure-1-b-spec.k 68.45 72.67 0.9419292692995734
erc20/hkg/transfer-success-1-spec.k 42.27 44.86 0.9422648238965672
benchmarks/ecrecoverloop00-sig1-invalid-spec.k 77.43 81.98 0.9444986582093193
mcd/cat-file-addr-pass-rough-spec.k 46.02 48.69 0.9451632778804684
erc20/hkg/transferFrom-success-2-spec.k 45.7 48.3 0.9461697722567289
erc20/ds/approve-success-spec.k 42.61 45.03 0.946258050188763
erc20/hkg/approve-spec.k 38.53 40.56 0.9499506903353057
erc20/ds/transferFrom-failure-1-b-spec.k 105.33 110.63 0.952092560788213
erc20/hkg/transfer-success-2-spec.k 41.38 43.21 0.9576486924323073
erc20/hkg/allowance-spec.k 38.55 40.06 0.9623065401897153
mcd/flopper-dent-guy-same-pass-rough-spec.k 526.28 546.26 0.9634240105444294
erc20/ds/transfer-failure-2-a-spec.k 53.71 55.59 0.966180967799964
kontrol/test-allowchangestest-testallow_fail-0-spec.k 41.8 40.38 1.035165923724616
benchmarks/ecrecoverloop00-sigs-valid-spec.k 55.24 53.23 1.0377606612812325
mcd/end-subuu-pass-spec.k 48.03 41.54 1.1562349542609534
TOTAL 2199.76 2638.1 0.8338425381903644

😮

@jberthold jberthold marked this pull request as ready for review July 29, 2024 12:20
@geo2a geo2a merged commit cff1bd6 into master Jul 29, 2024
6 checks passed
@geo2a geo2a deleted the HOTFIX-actually-use-smt-solver-for-equations branch July 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants