Make SMTContext mandatory and merge Unknown with ReasonUnknown #4003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
changed the title
geo2a
reviewed
Jul 29, 2024
geo2a
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
I like this change, I think it turned out to be quite a nice clean-up!
Hope @jberthold likes it too!
Co-authored-by: Georgy Lukyanov <[email protected]>
jberthold
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed my mind and think we should have
SMTContextmandatory and not an optional, as the current design makes it way too easy to give a defaultNothingvalue when extending the code-base in the future. This then has the potential to re-introduce a similar bug. Another advantage tot his approach is the removal of the ugly pattern matching present each time we actually want to use the solver.Instead, in this PR, the
Maybeis pushed intoSMTContext, where the dummy/empty instance now has to be consciously built using the newnoSolverfunction.The fallout is fairly minimal and we confide the logic of not having a solver to the SMT interface. I.e. the only places where not having a solver has a different behavior are:
hardReset- becomes a no-op when no solver handle is presentrunCmd-> always returns theUnknownresponse when no solver existsThis eliminates duplicate instances of handling an unknown response vs not having a solver, since in all instances of the current code-base, they are functionally the same.