Allow matching empty sets #4009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
approved these changes
Jul 30, 2024
jberthold
reviewed
Jul 30, 2024
Comment on lines
+386
to
+387
| emptySet | ||
| emptySet |
There was a problem hiding this comment.
Need to export emptySet from Test.Booster.Pattern.InternalCollections
Rest LGTM, we just have to fix this test.
geo2a
force-pushed
the
georgy/empty-set-matching
branch
from
54b5482 to
5201abd
Compare
geo2a
force-pushed
the
georgy/empty-set-matching
branch
from
a673ea7 to
1f149a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rudimentary matching of internalized sets: only empty sets are allowed to match, and an indeterminate result is returned for non-empty sets.