Booster interim simplification, refactor rewrite and logging parameters #4010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interim-simplification
|
Results for KEVM do not show much speedup /slowdown when using the option.
|
jberthold
commented
Jul 31, 2024
jberthold
changed the title
jberthold
force-pushed
the
EXPERIMENT-booster-interim-simplification
branch
from
4ef3106 to
cd2a4dd
Compare
jberthold
commented
Aug 1, 2024
Comment on lines
+109
to
+116
| # use special options if given, but restore KORE_RPC_OPTS afterwards | ||
| if [ ! -z "${FEATURE_SERVER_OPTS}" ]; then | ||
| echo "Using special options '${FEATURE_SERVER_OPTS}' via KORE_RPC_OPTS" | ||
| if [ ! -z "${KORE_RPC_OPTS:-}" ]; then | ||
| PRIOR_OPTS=${KORE_RPC_OPTS} | ||
| fi | ||
| export KORE_RPC_OPTS=${FEATURE_SERVER_OPTS} | ||
| fi |
There was a problem hiding this comment.
I put this in ad-hoc, it is helpful when new optional features are introduced (here: running with --simplify-each) but those options won't show in the log files for the timing, unfortunately.
geo2a
reviewed
Aug 1, 2024
geo2a
reviewed
Aug 1, 2024
geo2a
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--simplify-each DEPTHwhich runs a booster-only simplification everyDEPTHstepsLogOptionstypeperformRewriteandrunRewriteTto use a pre-madeRewriteConfig(extended by parameters required only inperformRewrite