Back-translate the SMTLIB unary minus, ignore models in "get-model" tests
#4033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
force-pushed
the
georgy/kore-get-model-fixes
branch
from
894f51f to
488804a
Compare
Back-translate (wrongly) unary minus Special-case the test script for get-model Remove special case for "-" Special-case unary minus in a different way add comment
geo2a
force-pushed
the
georgy/kore-get-model-fixes
branch
from
488804a to
6e4bb49
Compare
jberthold
reviewed
Aug 13, 2024
Comment on lines
539
to
540
| arg' <- backTranslate arg | ||
| pure $ TermLike.mkApplySymbol koreSym [mkInternalInt (InternalInt (simpleSort "SortInt") 0), arg'] |
There was a problem hiding this comment.
I think we should rather just negate the InternalInt that we expect inside arg, unless that does not work for some reason...
Suggested change
| arg' <- backTranslate arg | |
| pure $ TermLike.mkApplySymbol koreSym [mkInternalInt (InternalInt (simpleSort "SortInt") 0), arg'] | |
| arg' <- backTranslate arg | |
| case arg' of | |
| InternalInt intSort n -> pure $ InternalInt intSort (negate n) | |
| other -> throwError $ "unable to translate negation of " <> show other |
There was a problem hiding this comment.
Thanks, that worked, modulo juggling Kore's data constructors.
jberthold
approved these changes
Aug 14, 2024
goodlyrottenapple
approved these changes
Aug 14, 2024
rv-jenkins
pushed a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bridge PR that we need before bumping Z3 to 4.13.0.
test/rpc-server/runTests.pyto not compare the actual model from"get-model"responses, as it may be non-deterministic. Only compare the"satisfiable"field, i.e. model existence;"get-model"from SMTLIB2 s-expression to Kore, allow unary minus.