Skip to content

Fix handling of logging contextx in booster-dev #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix handling of logging contextx in booster-dev #4051

merged 2 commits into from
Sep 26, 2024

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Sep 25, 2024 •
edited
Loading

This small PR:

  • adds [request ID] contexts to logs emitted from booster-dev, similarly to kore-rpc-booster
  • the above also makes the per-defined logging contexts Booster.CLIOptions useful again, as they did not match before due to the absence of [request ID]
  • redirects the log messages to a file if asked for
  • also lists the available logging formats in --help

@geo2a geo2a requested a review from jberthold September 25, 2024 13:18
jberthold
jberthold approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geo2a geo2a merged commit 79caf8c into master Sep 26, 2024
6 checks passed
@geo2a geo2a deleted the georgy/fix-booster-dev-logging branch September 26, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberthold jberthold jberthold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geo2a @jberthold