Skip to content

Hotfix check/adjust subsorting for substitutions based on ==K terms #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

jberthold
Copy link
Member

When a constraint of shape VAR:VarSort ~> .K ==K term:TermSort ~> .K is externalised, the prior code just rendered a VAR:VarSort #Equals term:TermSort. This is wrong when TermSort /= VarSort, however TermSort will be a subsort of VarSort, otherwise the rule that introduced this ==K term is ill-sorted.

  • Externalisation code now inserts the missing injection into the #Equals expression.
  • A test was added which demonstrates the use case and behaviour (failed before, succeeds now).
  • A pretty-printer option was added to show the injections in the printed terms (off by default).

@jberthold jberthold requested review from geo2a and PetarMax November 26, 2024 08:28
Co-authored-by: Petar Maksimović <[email protected]>
@rv-jenkins rv-jenkins merged commit 26d79cb into master Nov 27, 2024
6 checks passed
@rv-jenkins rv-jenkins deleted the HOTFIX-subsort-k-equals-issue branch November 27, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants