Better error messages from hooks #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
force-pushed
the
better-errors
branch
from
69057e3 to
b4c868c
Compare
Baltoli
commented
Nov 21, 2022
Comment on lines
+276
to
+282
| #define KLLVM_HOOK_INVALID_ARGUMENT(msg) \ | ||
| do { \ | ||
| auto err_msg = std::string("[") + std::string(__func__) \ | ||
| + std::string("]: ") + std::string(msg); \ | ||
| throw std::invalid_argument(err_msg); \ | ||
| } while (false) | ||
|
|
There was a problem hiding this comment.
The changes in this PR are largely mechanical; replacing throw std::invalid_argument with a call to this macro.
dwightguth
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic identifier to every exception thrown by hooked function symbols in the LLVM backend.
The new output looks like this:
Note that the exact hook name printed each time may not precisely match the source of the error (because some hooks are implemented in terms of each other - e.g.
int2stringin terms ofbase2string), but this change will at least make it slightly easier to track down what the problem is.Closes #593