wasm demo completions support #2
Conversation
| additionalTextEdits: additional_text_edits, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It feels bad that we need to literally duplicate this between ra_lsp_server and wasm demo, but still, I think its the right thing to do. Wrapping rust-analyzer into some front-end is a ton of boilerplate (b/c the API surface is large), but it is still much easier than implementing the "compiler" itself.
There was a problem hiding this comment.
There might be some opportunity for reducing the code duplication, but that would probably require having an entire "lsp-types"-like crate for monaco.
This way rust-analyzer could have an intermediate crate mapping ra-ide to lsp, which both lsp-server and the wasm demo could use.
It sounds like too much effort to me, including the fact that monaco itself isn't stable and changes API regularly and does everything just a little differently.
|
@JasperDeSutter I've also granted you the permissions on this repository, in case I am slow with reviewing things :) |
|
cool! thanks 😄 |
Adds basic typing completions support to the wasm demo. Things such as functions, the rust-analyzer helpers (box, dbg...) work now.
This includes some refactoring to have the same
ConvandConvWith<CTX>as used in ra_lsp_server.