-
Notifications
You must be signed in to change notification settings - Fork 54
Fix typos, improve wording in latest blog post #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -7,7 +7,7 @@ Release: release:2020-07-20[] | |||
|
|||
== Sponsors | |||
|
|||
**Become a sponsor:** https://opencollective.com/rust-analyzer/[opecollective.com/rust-analyzer] | |||
**Become a sponsor:** https://opencollective.com/rust-analyzer/[opencollective.com/rust-analyzer] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, excellent catch!
bors r+ |
60: Fix typos, improve wording in latest blog post r=matklad a=jplatte Co-authored-by: Jonas Platte <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to question any particular change, I think all of them are improvements but not every one is required for grammatical correctness.
@@ -72,27 +72,27 @@ public class Main { | |||
|
|||
The user has just typed `Foo.f().`, and we need to figure out that the type of receiver expression is `Bar`, and suggest `g` as a completion. | |||
|
|||
First, as the `Main.java` file is modified, we run the indexer on this single file. | |||
Nothing has changed (the file still contains `Main` class with static `main` method), so we don't need to update FQN index. | |||
First, as the file `Main.java` is modified, we run the indexer on this single file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word swap here and in a few other places might not be required for grammatical correctness (I'm not actually sure), but it makes the article easier to read IMHO.
Timed out. |
bors isn't set up in this repo 😄. |
No description provided.