Skip to content

Fix typos, improve wording in latest blog post #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix typos, improve wording in latest blog post #60

merged 2 commits into from
Jul 20, 2020

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jul 20, 2020

No description provided.

@@ -7,7 +7,7 @@ Release: release:2020-07-20[]

== Sponsors

**Become a sponsor:** https://opencollective.com/rust-analyzer/[opecollective.com/rust-analyzer]
**Become a sponsor:** https://opencollective.com/rust-analyzer/[opencollective.com/rust-analyzer]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, excellent catch!

@matklad
Copy link
Member

matklad commented Jul 20, 2020

bors r+

bors bot added a commit that referenced this pull request Jul 20, 2020
60: Fix typos, improve wording in latest blog post r=matklad a=jplatte



Co-authored-by: Jonas Platte <[email protected]>
Copy link
Contributor Author

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to question any particular change, I think all of them are improvements but not every one is required for grammatical correctness.

@@ -72,27 +72,27 @@ public class Main {

The user has just typed `Foo.f().`, and we need to figure out that the type of receiver expression is `Bar`, and suggest `g` as a completion.

First, as the `Main.java` file is modified, we run the indexer on this single file.
Nothing has changed (the file still contains `Main` class with static `main` method), so we don't need to update FQN index.
First, as the file `Main.java` is modified, we run the indexer on this single file.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word swap here and in a few other places might not be required for grammatical correctness (I'm not actually sure), but it makes the article easier to read IMHO.

@bors
Copy link
Contributor

bors bot commented Jul 20, 2020

Timed out.

@lnicola
Copy link
Member

lnicola commented Jul 20, 2020

bors isn't set up in this repo 😄.

@matklad matklad merged commit 2b701ef into rust-analyzer:src Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants