Skip to content

Improve layout of sponsors #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Improve layout of sponsors #67

merged 1 commit into from
Aug 24, 2020

Conversation

Aloso
Copy link
Contributor

@Aloso Aloso commented Aug 17, 2020

Use a flex layout for sponsors that wraps on smaller screens and never breaks company names into multiple lines.

Desktop:

sponsors1

Mobile:

sponsors2

@Aloso
Copy link
Contributor Author

Aloso commented Aug 17, 2020

@matklad also, the website https://ferrous-systems.com/ has some serious problems. The menu on the mobile website doesn't work, and some text has poor contrast, making it impossible to read for people with poor eyesight. Sorry for writing this here, since I couldn't find an issue tracker for the Ferrous Systems website. Maybe you could reach out to the person who maintains it?

@matklad matklad merged commit ae503fb into rust-analyzer:src Aug 24, 2020
@matklad
Copy link
Member

matklad commented Aug 24, 2020

the website https://ferrous-systems.com/ has some serious problems

Yeah... We are not too good with html&css ourselves :(

The menu issue is fixed, we broke our assets pipline =/

@Aloso
Copy link
Contributor Author

Aloso commented Aug 24, 2020

@matklad to find text with poor contrast, you can use the Firefox dev tools. They have an accessibility panel for finding various problems. The Chrome dev tools have a "lighthouse" panel that reports even more problems (it's like clippy, but for websites).

@Aloso Aloso deleted the sponsors branch December 23, 2020 11:56
lnicola added a commit that referenced this pull request Mar 8, 2021
lnicola added a commit that referenced this pull request Mar 8, 2021
lnicola added a commit that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants