Adds importdescriptors #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Closed
|
Finally tested this! Sorry for the delay, we had to merge it into our own branch for testing. This worked for us. |
|
I'm not sure why CI isn't running -- could you make sure that |
|
cc @sr-gi fixing the format is blocking merge. utACK otherwise. |
Adds `importdescriptors` rpc. `ImportMultiRescanSince` to Timestamp given it is not being used solely for MultiRescan anymore. Feels like `ImportMultiResult` should also be renamed, given it is now used by both `importmulti` and `importdescriptors`. I haven't found a proper name for it though.
sr-gi
force-pushed
the
import_descriptors
branch
from
4c35184 to
718ba56
Compare
Should be fixed now. I've also rebased master given this was forking from an old tip. |
|
Also, the commit I tested was 4c35184. |
|
Confirmed that the rebase is a pure rebase except to drop a newline that |
apoelstra
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
importdescriptorsrpc. I've renamedImportMultiRescanSincetoTimestampgiven it is not being used solely for multi rescan anymore.Feels like
ImportMultiResultshould also be renamed, given it is now used by bothimportmultiandimportdescriptors. I haven't found a proper name for it though.