Skip to content

add combine raw transaction #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2022
Merged

add combine raw transaction #270

merged 1 commit into from
Dec 30, 2022

Conversation

thesimplekid
Copy link
Contributor

No description provided.

@apoelstra
Copy link
Member

I'm a little skeptical about this test, which tries combining a transaction with itself and merely checks that the output is nonempty. But because this RPC is so simple (no data structures, just strings in and strings out) I'm willing to let it go.

apoelstra
apoelstra approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a8bec6

apoelstra
apoelstra approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a8bec6

@apoelstra apoelstra merged commit 4ff70e8 into rust-bitcoin:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesimplekid @apoelstra