Derive std::hash::Hash for Descriptor et al #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK, looks like there are some rust 1.29 errors |
Bunch of other types that needed hash to be able to derive it.
|
I pushed some CI fixes here, if you prefer them separate, I can take them apart. |
|
@stevenroose when we derive |
apoelstra
approved these changes
Apr 21, 2021
|
(To clarify my above comment -- this PR fixes the issue by putting a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, I'm quite confused by this. The
Miniscripttype derivesHashwithout theScriptContexttrait requiringHash, but when I tried forDescriptorit would complain about that. Is there some magic that made it work inMiniscript? Ideally we wouldn't require theHashonScriptContextthere, but it doesn't hurt either.