Skip to content

Add timelock mix tests from miniscript alloy spec #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

sanket1729
Copy link
Member

There found one bug in the current type system! The last commit disables the test while I work on fuzzer fix for rust-secp256k1.

@apoelstra
Copy link
Member

Can you rebase this? Github is confused and is still showing two commits from #257 in this.

@sanket1729
Copy link
Member Author

Rebased

@sanket1729
Copy link
Member Author

sanket1729 commented Sep 8, 2021

But this still has bugs, I am yet to address the changes to fuzz tests and removing the #[cfg(not(fuzzing))] thing
Ready for review again

@apoelstra
Copy link
Member

Do these tests need to be ignored? On my system they run in less than a second.

@sanket1729
Copy link
Member Author

No, these run really fast. I don't think the ignored is needed.

Fix bugs from alloy spec

Possibly has some bugs in j: wrapper implementation. Will squash this
commit later
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 003226e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants