Fix over-generic parameterization of ScriptContext #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sanket1729 |
|
lol great catch. post-merge concept ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous genericization of the ScriptContext methods permitted some very surprising behaviors that are certainly not intended. The Ctx Parameters should in all cases be a Self parameter as far as I can tell. This PR fixes this issue.
fixes #255 (comment)
Technically, this is a breaking change as the generic paremeter count decreases and it is not generally inferred I think. It's easy to fix, and any code which could not be fixed trivially would be hopelessly broken/buggy.