Skip to content

use a single-use temp name for integration test dir #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

use a single-use temp name for integration test dir #288

merged 1 commit into from
Jan 11, 2022
+2 −1

Conversation

6293
Copy link
Contributor

@6293 6293 commented Dec 26, 2021

Closes #287

@apoelstra
Copy link
Member

Can you use xxd rather than base64 so we get hex-encoding? 10 digits is still more than enough.

As an aside, do we care about support for systems without /dev/urandom or anything like it? I guess not.

@6293
Copy link
Contributor Author

6293 commented Dec 26, 2021

As an aside, do we care about support for systems without /dev/urandom or anything like it? I guess not.

Maybe it is better to use timestamp instead of random string, because what we want to do is to avoid conflict on the shared machine. We should be ok with just date

@6293 6293 force-pushed the integration-test-rand-dir branch from b5050b0 to ea4abcf Compare December 26, 2021 15:16
@6293
Copy link
Contributor Author

6293 commented Dec 26, 2021

updated to use xxd

@sanket1729
Copy link
Member

Bitcoin core names it as /tmp/bitcoin_func_test_o16z4jkv. Anyways, I am okay with xxd or base64

@6293 6293 force-pushed the integration-test-rand-dir branch from ea4abcf to 371c23c Compare December 26, 2021 15:42
@6293 6293 force-pushed the integration-test-rand-dir branch from 371c23c to e3dafb2 Compare December 26, 2021 15:42
sanket1729
sanket1729 approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e3dafb2

@apoelstra
Copy link
Member

utACK the current proposal (use /dev/urandom into xxd, add prefix)

apoelstra
apoelstra approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e3dafb2

This looks great!

@sanket1729 sanket1729 merged commit 13e7552 into rust-bitcoin:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a random name for integration test directory
3 participants
@6293 @apoelstra @sanket1729