Add support for x-only keys in descriptor #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Feb 14, 2022
src/miniscript/context.rs
Outdated
| @@ -45,6 +45,9 @@ pub enum ScriptContextError { | |||
| /// Only Compressed keys allowed under current descriptor | |||
| /// Segwitv0 fragments do not allow uncompressed pubkeys | |||
| CompressedOnly(String), | |||
| /// XOnly keys are only allowed in Tap context | |||
| /// The first element is key, and second element is current script context | |||
| XOnlyKeysNotAllowed(String, String), | |||
There was a problem hiding this comment.
In cbd02d4:
I think the second String could be a &'static str
apoelstra
reviewed
Feb 14, 2022
src/descriptor/key.rs
Outdated
| @@ -427,7 +460,10 @@ impl DescriptorPublicKey { | |||
| self | |||
| } | |||
|
|
|||
| /// Computes the public key corresponding to this descriptor key | |||
| /// Computes the public key corresponding to this descriptor key. | |||
| /// When deriving from an XOnlyPublicKey, it adds the default 0x02 y-ordinate | |||
apoelstra
reviewed
Feb 14, 2022
src/descriptor/mod.rs
Outdated
| /// Derive a [`Descriptor`] with a concrete [`bitcoin::PublicKey`] at a given index | ||
| /// Removes all extended pubkeys and wildcards from the descriptor and only leaves | ||
| /// concrete [`bitcoin::PublicKey`]. All [`crate::XOnlyKey`]s are converted to [`bitcoin::PublicKey`] | ||
| /// by adding a default(0x02) y-ordinate. For [`crate::descriptor::Tr`] descriptor, |
There was a problem hiding this comment.
In f2d7bde:
y-ordinate again. Is this a term that I don't know? :)
|
Done reviewing f2d7bde |
sanket1729
force-pushed
the
add_desc_key
branch
from
f2d7bde to
602e94f
Compare
|
Addressed the comments. |
apoelstra
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.