Skip to content

Update derived_descriptor signature and related examples #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

Update derived_descriptor signature and related examples #303

merged 1 commit into from
Mar 9, 2022
+4 −6

Conversation

Eunoia1729
Copy link
Contributor

@Eunoia1729 Eunoia1729 commented Mar 7, 2022 •
edited
Loading

Description

Resolves #302.

  • Updates the order of parameters in derived_descriptor function signature.
  • Updates the P2WSH-P2SH and ranged xpub examples to call derived_descriptor function.

@apoelstra apoelstra closed this Mar 8, 2022
@apoelstra apoelstra reopened this Mar 8, 2022
apoelstra
apoelstra approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2a695f8

Much nicer!

sanket1729
sanket1729 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2a695f8

@sanket1729 sanket1729 merged commit bb63808 into rust-bitcoin:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the parameters of derived_descriptor
3 participants
@Eunoia1729 @apoelstra @sanket1729