MultiA interpreter #308
Merged
MultiA interpreter #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for multi_a descriptor. Upcoming integration test PR will add tests for these
dr-orlovsky
reviewed
Mar 14, 2022
| // push 1 on satisfied sigs and push 0 on empty sigs | ||
| match self | ||
| .stack | ||
| .evaluate_pk(&mut self.verify_sig, &subs[node_state.n_evaluated]) |
There was a problem hiding this comment.
wouldn't subs[node_state.n_evaluated] panic if the number of the provided signatures is less than k?
There was a problem hiding this comment.
n_evaluated denotes the numbers of sub-expressions evaluated, not the number of sigs. The number of expressions evaluated must be less than subs.len() because we add +1 whenever we evaluate one sub-expression.
Inside evalute_pk, there is a check that checks if we have one sig for a given pk. This will correctly error if given sigs is less than the number of keys.
There was a problem hiding this comment.
At some distant future a test for that will be nice to have :)
There was a problem hiding this comment.
Will add in this one. Should be a couple mins of work
sanket1729
force-pushed
the
multi_interpreter
branch
from
d30d8c6 to
3114ec4
Compare
sanket1729
force-pushed
the
multi_interpreter
branch
from
3114ec4 to
251921e
Compare
Merged
sanket1729
added a commit
that referenced
this pull request
Mar 21, 2022
13c4746 Update CI to test on 22.0 instead of 0.21 (sanket1729) 51126d3 Add taproot tests (sanket1729) c25fc05 Add descriptor integration tests (sanket1729) ae3c98e Move only: Rework Integration Test and makes things more modular (sanket1729) Pull request description: This is the final PR testing of many of the new features in the taproot miniscript release. This defines a new template language for checking all the Psbt APIs (and thereby all the miniscript ones). ```rust // K : Compressed key available // K!: Compressed key with corresponding secret key unknown // X: X-only key available // X!: X-only key with corresponding secret key unknown // Test 1: Simple spend with internal key let wit = test_desc::test_desc_satisfy(cl, testdata, "tr(X)"); assert!(wit.len() == 1); ``` Right now, it does not test error cases, but I plan to update this framework so that we can also test those. Based on #308 and #310 ACKs for top commit: apoelstra: ACK 13c4746 Tree-SHA512: ce39c9b0242460e70f79c57843c69be36de045da6bcc686306a324c7fe58b70a5fe45e858c266a1f816f4e7f8aaf570fb42f64e543de86e2d786e1fa3fa0beb4
sanket1729
added a commit
to sanket1729/elements-miniscript
that referenced
this pull request
May 18, 2022
bc2d097 Merge rust-bitcoin/rust-miniscript#308: MultiA interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multi_a interpreter. Required for interpreter check finalizer.