Skip to content

Fix tr for each key bug #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Conversation

sanket1729
Copy link
Member

You can re-order commits to see that this is fixed.

@sanket1729
Copy link
Member Author

cc @dr-orlovsky

@sanket1729 sanket1729 added the RC-fix To be merged before major release label Mar 22, 2022
Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 92e504c

Tested with my wallet, now it works:

xpub:
  tpubDC7mz8DJG7cy72MomPR2TmkfA6kjqYkEtYPHigBcycRaaPGD4fgmS8WWADEPNN685xVepi8nee1xGEYR33iNj9hy5HpqhtAKTT2uq4uq7jv:
    - 877c9433
    - "m/86'/1'/0'"
  tpubDC7mz8DJG7cyYEWffExngTpWvjn6rZqaAkugaiHKVzsw9jA5fL7Ch8G2KSxGpraZZNYEKaH4uDExLbtE5ySBA49ZZfP6aXjvAHVyyxjEEeu:
    - 877c9433
    - "m/86'/1'/10'"
  tpubDC7mz8DJG7cyb3BEFXtK1FbvoD3Y81RTjqUUvkaZDXbQExaaMAg1gNy1yLQeRYbL94eFfQ4WymxksrWJJYCLh7Fwrs1e5wG1TwAsKrruUS9:
    - 877c9433
    - "m/86'/1'/11'"
  tpubDC7mz8DJG7cycqGg8AnwnvRT2Gwwgr9tf6Xv8ejs6Ec5gcg1PPnukYnwUADsb6EQPT3SdHg6zrC9WRwoPUan2PpaqtNRbUJxWZJkGmeh1HZ:
    - 877c9433
    - "m/86'/1'/12'"

Previosly it was just two keys, not four)

@dr-orlovsky
Copy link
Contributor

May I ask please to do RC2 after the fix merge?

@sanket1729
Copy link
Member Author

I think we want to do another RC after next RC for rust-bitcoin

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92e504c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RC-fix To be merged before major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants