Skip to content

integration_test: Enable edition 2018 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2022

Conversation

tcharding
Copy link
Member

As we did for the main crate, enable edition 2018 in the integration_test crate.

tcharding added 3 commits May 3, 2022 11:09
Enable edition 2018 in the manifest and remove usage of `extern crate`.
Cargo emits warning:

 warning: hidden lifetime parameters in types are deprecated

As suggested, use the anonymous lifetime.
As we have edition 2018 we no longer need to import `bitcoin`
explicitly.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3188d06

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3188d06

@sanket1729 sanket1729 merged commit 1d194d3 into rust-bitcoin:master May 9, 2022
@tcharding tcharding deleted the int-tests-edition-2018 branch May 10, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants