Make the integration script more quiet #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We unconditionally kill `bitcoind` in the integration test script. This is correct but when there is no `bitcoind` process running results in a output `bitcoind: no process found`. This output is misleading because it makes one think that `bitcoind` didn't start up correctly. Send the stderr warning to `/dev/null`.
Currently we echo PATH at the start of ever run of the integration test scritp, it is not immediately apparent why we do this. Presumably it was done during some debugging effort. Do not echo `$PATH` when running the integration test script.
apoelstra
reviewed
May 6, 2022
| killall -9 bitcoind | ||
|
|
||
| echo $PATH | ||
| killall -9 bitcoind 2> /dev/null |
There was a problem hiding this comment.
lol, I had no idea this line was here. This is pretty anti-social. But it has nothing to do with this PR, so that's fine.
There was a problem hiding this comment.
Couldn't think of a quick thorough fix so I raised an issue: #395
There was a problem hiding this comment.
I may be to blame here. I was trying to make the script work without thinking of all the consequences.
apoelstra
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have two initial output lines when running the integration test script. The first is confusing (to me at least) and the second is unnecessary it seems (please correct me if I am wrong).
bitcoind: no process found$PATH