Add default impl for Miniscript::num_der_paths
#578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
changed the title
Miniscript::num_der_paths
tcharding
force-pushed
the
07-27-default-num-der-paths
branch
from
080d735 to
a322217
Compare
apoelstra
previously approved these changes
Jul 27, 2023
apoelstra
previously approved these changes
Jul 27, 2023
tcharding
dismissed
apoelstra’s stale review
The merge-base changed after approval.
apoelstra
previously approved these changes
Jul 27, 2023
tcharding
dismissed
apoelstra’s stale review
The merge-base changed after approval.
|
Lol fucking github. |
The trait method `MiniscriptKey::num_der_paths` often returns 0, lets just make this the default.
tcharding
force-pushed
the
07-27-default-num-der-paths
branch
from
a322217 to
88f7f5b
Compare
|
Changed the last patches hash just to kick CI, no changes. |
apoelstra
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trait method
MiniscriptKey::num_der_pathsoften returns 0, lets just make this the default.