Remove written in clause #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #579 |
apoelstra
approved these changes
Jul 27, 2023
Recently we discussed in `rust-bitcoin` the pointlessness of the `\\ Written in ...` clause above the license terms. We came to the conclusion that: - It probably wasn't written then and who cares anyway because we patch files all the time - It almost certainly wasn't written by just this person because we have a bunch of contributors - Use of "the rust bitcoin devs" is just noise and no signal Remove the "written in" clause if it contains "the rust bitcoin devs" or Andrew's name (because he was part of the conversation in rust-bitcoin) Do no remove clauses that have Sanket's name or Maxim's. Its up to them if they want attribution so we leave it there for now. Leave Andrew's name in `lib.rs` as a little nod-of-the-head to him as the original author. I do not know the full relationship between Sanket and Andrew and who did what so please forgive me Sanket if this is wrong.
tcharding
force-pushed
the
07-27-rm-written-in
branch
from
6064cdd to
87a16ef
Compare
|
Rebased on master, no other changes. |
apoelstra
approved these changes
Jul 27, 2023
|
Will let @sanket1729 check this and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we discussed in
rust-bitcointhe pointlessness of the\\ Written in ...clause above the license terms. We came to the conclusion that:Remove the "written in" clause if it contains "the rust bitcoin devs" or Andrew's name (because he was part of the conversation in rust-bitcoin)
Do no remove clauses that have Sanket's name or Maxim's. Its up to them if they want attribution so we leave it there for now.
Leave Andrew's name in
lib.rsas a little nod-of-the-head to him as the original author. I do not know the full relationship between Sanket and Andrew and who did what so please forgive me Sanket if this is wrong.