Do some random trivial fixes #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing rustfmt check. |
The use of `Terminal::Foo` repeatedly clutters the code with no added meaning, we can import all the variants and make the code more terse and easier to read. Refactor only, no logic changes.
tcharding
force-pushed
the
07-27-random-trivial-fixes
branch
from
be7bee6 to
7c50ded
Compare
|
Rebased on master and fixed formatting issues. |
The `Terminal` type as unambiguous, no need to qualify it.
tcharding
force-pushed
the
07-27-random-trivial-fixes
branch
from
7c50ded to
4067238
Compare
apoelstra
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes explained in their respective patch.