ci: pin nightly rust compiler version #799
Merged
+81
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds on #798 |
|
Oh, heh, it doesn't build on 798 -- but it does need 798 to pass CI. |
sanket1729
reviewed
Mar 27, 2025
I believe that our previous use of the `rev:` key had no effect. We need to use `ref:` with a full commit ID. As written, I think that we were just always pulling master, even though it looked like a commit ID. Anyway we don't use any cool features of rust-bitcoin-maintainer-tools so it doesn't really matter here. But we should pin it properly.
apoelstra
force-pushed
the
2025-03--pin-ci
branch
from
293c18d to
a713ee7
Compare
apoelstra
force-pushed
the
2025-03--pin-ci
branch
from
a713ee7 to
6df8cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were most of the way there already.
I added
secrets.APOELSTRA_CREATE_PR_TOKENto this repo so the weekly cronjob should work. I just copy/pasted the code from rust-bitcoin.