Split up the Keyboard type. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have separate types for decoding the PS/2 bitstream, processing Scan Codes into KeyEvents, and decoding KeyEvents according to the current layout. Also adds an 'AnyLayout' type which lets you swap layouts at run-time.
jonathanpallant
force-pushed
the
split-types
branch
from
1c8c0d4 to
71e571e
Compare
jannic
reviewed
Feb 10, 2023
Co-authored-by: Jan Niehusmann <[email protected]>
|
Fixed the comments on the layout types to use Oem5 and Oem7, because that's electrically fixed by the choice of ANSI or ISO and doesn't vary with what you've printed on the keycaps. Also German QWERTZ is 105 key so I renamed it. |
jannic
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have separate types for decoding the PS/2 bitstream, processing Scan Codes into KeyEvents, and decoding KeyEvents according to the current layout.
Also adds an 'AnyLayout' type which lets you swap layouts at run-time.
Closes #30