mark all assembly functions as .thumb_func #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works around a [LLD bug] related to interworking. [LLD bug]: https://bugs.llvm.org/show_bug.cgi?id=38435
|
r? @adamgreig (chosen at random) |
|
LGTM too, @bors r+ |
|
@adamgreig it's actually "bors r+". (see https://bors.tech/documentation/getting-started/) bors r=adamgreig |
bors bot
added a commit
that referenced
this pull request
Aug 7, 2018
103: mark all assembly functions as .thumb_func r=adamgreig a=japaric this works around a [LLD bug] related to interworking. [LLD bug]: https://bugs.llvm.org/show_bug.cgi?id=38435 Co-authored-by: Jorge Aparicio <[email protected]>
|
Ah thanks, I was misled by the old Homu docs I think! bors r+ |
|
Not awaiting review |
Build succeeded |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
103: v0.6.0 r=therealprof a=japaric this also adds compile-fail soundness tests and patches a soundness issue in `#[entry]` commit required to release a new (minor) version r? @rust-embedded/cortex-m (anyone) Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this works around a LLD bug related to interworking.