Skip to content

Always expose the VTOR register (#100) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

gkelly
Copy link
Contributor

@gkelly gkelly commented Aug 8, 2018

Cortex-M0+ platforms had the VTOR register hidden because of the way the
SCB chose to expose it. This change exposes it on all platforms, with
the side effect that it will be visible on Cortex-M0 even thought the M0
SCB does not define it.

Cortex-M0+ platforms had the VTOR register hidden because of the way the
SCB chose to expose it.  This change exposes it on all platforms, with
the side effect that it will be visible on Cortex-M0 even thought the M0
SCB does not define it.
@gkelly gkelly requested a review from a team as a code owner August 8, 2018 16:30
@japaric
Copy link
Member

japaric commented Aug 8, 2018

Thanks @gkelly!

The team discussed this in #100 and there was consensus on implementing this solution.

bors r+

bors bot added a commit that referenced this pull request Aug 8, 2018
104: Always expose the VTOR register (#100) r=japaric a=gkelly

Cortex-M0+ platforms had the VTOR register hidden because of the way the
SCB chose to expose it.  This change exposes it on all platforms, with
the side effect that it will be visible on Cortex-M0 even thought the M0
SCB does not define it.

Co-authored-by: Garret Kelly <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 8, 2018

Build succeeded

@bors bors bot merged commit 88726d9 into rust-embedded:master Aug 8, 2018
@gkelly gkelly deleted the expose-vtor branch August 8, 2018 18:35
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
104: v0.6.0, take 2 r=therealprof a=japaric

the dev-dependency of cortex-m-rt-macros needs to specify a version or can't be
published; this commit fixes that

docs.rs won't be able to build docs for these two crates so this also changes
the documentation link to https://rust-embedded.github.io/cortex-m-rt/ where I
have (manually) implemented a poor man's docs.rs

now we should be able to publish a new version

r? @rust-embedded/cortex-m (anyone)

Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants