deprecate NVIC.{clear,set}_pending in favor of NVIC::{un,}pend #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVIC::{un,}pend are static methods that don't require an instance of NVIC to be
invoked.
therealprof
approved these changes
Oct 27, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 27, 2018
120: deprecate NVIC.{clear,set}_pending in favor of NVIC::{un,}pend r=therealprof a=japaric
NVIC::{un,}pend are static methods that don't require an instance of NVIC to be
invoked.
Rationale: These operations perform writes to stateless registers so they can
*not* result in data races.
More tricky is the question of whether letting the user call these from any
execution context without any critical section or other means of synchronization
can result in memory unsafety when used in conjunction with methods like
NVIC.{get,set}_priority that do require an instance of NVIC. I can't foresee any
trouble given that these methods (e.g. pend and set_priority) operate on
different registers.
Co-authored-by: Jorge Aparicio <[email protected]>
Build succeeded |
japaric
added a commit
that referenced
this pull request
Oct 27, 2018
japaric
added a commit
that referenced
this pull request
Oct 27, 2018
bors bot
added a commit
that referenced
this pull request
Oct 27, 2018
121: v0.5.8 r=therealprof a=japaric required to make a release we can publish now or wait for #120 Co-authored-by: Jorge Aparicio <[email protected]>
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVIC::{un,}pend are static methods that don't require an instance of NVIC to be
invoked.
Rationale: These operations perform writes to stateless registers so they can
not result in data races.
More tricky is the question of whether letting the user call these from any
execution context without any critical section or other means of synchronization
can result in memory unsafety when used in conjunction with methods like
NVIC.{get,set}_priority that do require an instance of NVIC. I can't foresee any
trouble given that these methods (e.g. pend and set_priority) operate on
different registers.