add thumbv8m baseline support #123
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
approved these changes
Nov 3, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 3, 2018
123: add thumbv8m baseline support r=therealprof a=evq Co-authored-by: eV <[email protected]>
Build succeeded |
|
Thank you! I had exactly the same diff ;) |
Closed
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
123: respect declared unsafety r=therealprof a=japaric
the `#[entry]` and `#[exception]` attributes ignored the declared unsafety and
always expanded to a safe function. This caused the following valid code to
error at compile time:
``` rust
#[entry]
unsafe fn main() -> ! {
foo();
//~^ ERROR call to unsafe function is unsafe and requires unsafe function or block
loop {}
}
unsafe fn foo() {}
```
r? @rust-embedded/cortex-m (anyone)
Co-authored-by: Jorge Aparicio <[email protected]>
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
this is a backport of PR #123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.