Fix __delay asm function for the thumbv6m-none-eabi target #152
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
|
@Disasm The file sizes of the binaries are weird. Can you show a before/after objdump of thumbv7m and thumbv8m.main? |
|
*** thumbv7m-none-eabi.before 2019-07-05 00:53:44.912959913 +0300
--- thumbv7m-none-eabi.after 2019-07-05 00:54:32.731009376 +0300
***************
*** 32,39 ****
00000000 <__delay>:
0: bf00 nop
2: 3801 subs r0, #1
! 4: f47f affe bne.w 0 <__delay>
! 8: 4770 bx lr
Disassembly of section .text.__dmb:
--- 32,39 ----
00000000 <__delay>:
0: bf00 nop
2: 3801 subs r0, #1
! 4: d1fc bne.n 0 <__delay>
! 6: 4770 bx lr
Disassembly of section .text.__dmb:
*** thumbv8m.main-none-eabi.before 2019-07-05 00:53:44.919626307 +0300
--- thumbv8m.main-none-eabi.after 2019-07-05 00:54:32.737675770 +0300
***************
*** 32,39 ****
00000000 <__delay>:
0: bf00 nop
2: 3801 subs r0, #1
! 4: f47f affe bne.w 0 <__delay>
! 8: 4770 bx lr
Disassembly of section .text.__dmb:
--- 32,39 ----
00000000 <__delay>:
0: bf00 nop
2: 3801 subs r0, #1
! 4: d1fc bne.n 0 <__delay>
! 6: 4770 bx lr
Disassembly of section .text.__dmb:
".before" files were created on the |
|
Also just regenerating the binaries on master increases |
|
Okay then. |
|
bors r+ |
152: Fix __delay asm function for the thumbv6m-none-eabi target r=therealprof a=Disasm Before: ``` 00000000 <__delay>: 0: 46c0 nop ; (mov r8, r8) 2: 3801 subs r0, #1 4: d1fe bne.n 0 <__delay> 4: R_ARM_THM_JUMP8 __delay 6: 4770 bx lr ``` After: ``` 00000000 <__delay>: 0: 46c0 nop ; (mov r8, r8) 2: 3801 subs r0, #1 4: d1fc bne.n 0 <__delay> 6: 4770 bx lr ``` Closes #125 Co-authored-by: Vadim Kaushan <[email protected]>
Build succeeded |
152: doc related changes r=adamgreig a=japaric see individual commit messages for details Co-authored-by: Jorge Aparicio <[email protected]>
Before:
After:
Closes #125