Skip to content

Remap debuginfo paths #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Remap debuginfo paths #255

merged 1 commit into from
Aug 18, 2020

Conversation

jonas-schievink
Copy link
Contributor

cc #254

@jonas-schievink jonas-schievink requested a review from a team as a code owner August 18, 2020 19:23
@rust-highfive
Copy link

r? @thalesfragoso

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Aug 18, 2020
therealprof
therealprof approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whee, that looks gnarly. Looks good on a first glance but the result could use a second look.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 18, 2020

Build succeeded:

@bors bors bot merged commit d57bff9 into rust-embedded:master Aug 18, 2020
@jonas-schievink jonas-schievink deleted the paths branch August 18, 2020 23:29
@therealprof
Copy link
Contributor

I had a peek into the generated binaries and looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@thalesfragoso thalesfragoso

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonas-schievink @rust-highfive @therealprof @thalesfragoso