Skip to content

Replace shell scripts with integration test #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

Replace shell scripts with integration test #261

merged 1 commit into from
Aug 28, 2020

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Aug 28, 2020 •
edited
Loading

  • Removes the Clippy check from CI (I don't think we should fail CI when Clippy finds something, it seems better to use the GitHub Actions plugin)
  • Tests all targets (thumbv8m.base was missing)
  • Bumps MSRV to 1.35.0 (to get the thumbv8m.base libcore)

@rust-highfive
Copy link

r? @thalesfragoso

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Aug 28, 2020
@jonas-schievink
Copy link
Contributor Author

jonas-schievink commented Aug 28, 2020 •
edited
Loading

Hmm, do we not configure bors to look for the travis builders? Helps if you don't delete the file by accident

@jonas-schievink jonas-schievink marked this pull request as ready for review August 28, 2020 17:59
@jonas-schievink jonas-schievink requested a review from a team as a code owner August 28, 2020 17:59
therealprof
therealprof approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 28, 2020

Build succeeded:

@bors bors bot merged commit 54f541c into rust-embedded:master Aug 28, 2020
@jonas-schievink jonas-schievink deleted the language-bashing branch August 28, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@thalesfragoso thalesfragoso

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonas-schievink @rust-highfive @therealprof @thalesfragoso