Implement InterruptNumber for bare_metal::Nr #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
I was kinda hoping we would march towards 1.0 rather sooner than later. 😅 Other than that, looks fine to me. Other opions? @jonas-schievink @thalesfragoso |
thalesfragoso
previously approved these changes
Sep 21, 2020
therealprof
requested changes
Sep 21, 2020
therealprof
reviewed
Sep 21, 2020
CHANGELOG.md
Outdated
| @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| - New `InterruptNumber` trait is now required on interrupt arguments to the | |||
| various NVIC functions, replacing the previous use of `Nr` from bare-metal. | |||
| For backwards compatibility, `InterruptNumber` is implemented for types | |||
| which are `Nr + Copy`, but this will be removed in cortex-m v0.8. | |||
There was a problem hiding this comment.
Do we really want to tie this to a specific version already?
adamgreig
force-pushed
the
impl-nr-for-nr
branch
from
b9ec60c to
b7541dd
Compare
therealprof
approved these changes
Sep 21, 2020
|
Build succeeded: |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
287: Fix common uses of INSERT AFTER with .bss and .text r=adamgreig a=mattico Fixes #267 Fixes #266 This fixes two related issues. 1. Named sections are often inserted after `.bss` or `.text` in order to have them handled as if they were part of that section. Defining the start/end symbols outside of the section allows this to work. 2. Uninitialized C statics will end up as common symbols which end up in the COMMON input section. If this section is orphaned, it will likely end up placed after `.bss`. C code often expects these statics to be zero initialized. The first change would cause these symbols to be placed before `__ebss` so they will get zeroed by the reset handler. Explicitly placing the common symbols into `.bss` ensures this happens. Users who want uninitialized symbols should use the `.uninit` section. See rust-embedded/cortex-m-rt#287 (comment) Co-authored-by: Matt Ickstadt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to help backwards compatibility by implementing the new
InterruptNumbertrait (coming in cortex-m 0.7) for the oldbare_metal::Nrtrait. With this included in cortex-m 0.7, existing PACs generated from the current svd2rust (0.17) will work with cortex-m 0.7, and new PACs generated from a to-be-released svd2rust which uses `InterruptNumber directly will also work.We can then remove this implementation in cortex-m 0.8 and upgrade cortex-m to depend on bare-metal 1.0 (or not depend on it at all) at that time.
With this PR in place, the upgrade path looks like: