Skip to content

Fix #414, use fully qualified path for exception enum in #[exception] macro #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

adamgreig
Copy link
Member

Partially reverts rust-embedded/cortex-m-rt#224
to continue to use a fully-qualified path to exception.

Partially reverts rust-embedded/cortex-m-rt#224
to continue to use a fully-qualified path to `exception`.
@rust-highfive
Copy link

r? @thalesfragoso

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Jan 26, 2022
Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 27, 2022

@bors bors bot merged commit 0939281 into master Jan 27, 2022
@bors bors bot deleted the fix-414 branch January 27, 2022 22:58
yvt added a commit to r3-os/r3 that referenced this pull request Jun 8, 2022
These macros are no longer usable by fully-qualified paths after
[rust-embedded/cortex-m-rt#224][1].

Although this change was later partially reverted by
[rust-embedded/cortex-m#416][2], the version that includes this fix is
not released yet.

[1]: rust-embedded/cortex-m-rt#224
[2]: rust-embedded/cortex-m#416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants