Skip to content

semihosting: silence clippy::result_unit_err in hio #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2023
Merged

semihosting: silence clippy::result_unit_err in hio #492

merged 1 commit into from
Nov 4, 2023

Conversation

newAM
Copy link
Member

@newAM newAM commented Oct 29, 2023

Fixing this lint requires a breaking change that does not add much value in my opinion.

Alternatively I can make the breaking change to fix this:

  • hstdout and hstderr return Option<HostStream> instead of Result<HostStream, ()>
  • write_all
    • Option 1: Returns bool with #[must_use = "Return bool is true if an error occurred"]
    • Option 2: Add a pub struct Error(()); type and return Result<(), Error>

@newAM newAM requested a review from a team as a code owner October 29, 2023 22:59
@adamgreig adamgreig added this pull request to the merge queue Nov 4, 2023
Merged via the queue into rust-embedded:master with commit 7f4c271 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newAM @adamgreig