cortex-m: add support for embedded-hal 1.0 delays #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix the unrelated CI failures - but might not have time for that tonight. |
|
Is it worth feature-gating e-h 0.2, so it's available if someone wants it but doesn't pull in both versions as dependencies otherwise? |
|
I think that makes sense, but also the rp2040-hal is likely going to pull in eh-0.2 unconditionally. |
newAM
force-pushed
the
eh1
branch
2 times, most recently
from
cb3a5c6 to
2ba551b
Compare
rursprung
added a commit
to rursprung/avr-hal
that referenced
this pull request
Jan 15, 2024
blatantly taken from rust-embedded/cortex-m#504 Co-Authored-By: Alex Martens <[email protected]>
Rahix
pushed a commit
to Rahix/avr-hal
that referenced
this pull request
Jan 15, 2024
blatantly taken from rust-embedded/cortex-m#504 Co-Authored-By: Alex Martens <[email protected]>
jannic
reviewed
Jan 30, 2024
qwandor
approved these changes
Feb 5, 2024
rursprung
added a commit
to rursprung/avr-hal
that referenced
this pull request
Feb 12, 2024
this is a follow-up to commit 403cf3b / PR Rahix#492, based on a review commit on cortex-m (see PR [cortex-m#504]). [cortex-m#504]: rust-embedded/cortex-m#504 (comment)
rursprung
added a commit
to rursprung/avr-hal
that referenced
this pull request
Feb 12, 2024
this is a follow-up to commit 403cf3b / PR Rahix#492, based on a review comment by @jannic on cortex-m (see PR [cortex-m#504]). [cortex-m#504]: rust-embedded/cortex-m#504 (comment)
Rahix
pushed a commit
to Rahix/avr-hal
that referenced
this pull request
Feb 13, 2024
This is a follow-up to commit 403cf3b / PR #492, based on a review comment by @jannic on cortex-m (see PR [cortex-m#504]). [cortex-m#504]: rust-embedded/cortex-m#504 (comment)
adamgreig
approved these changes
Feb 18, 2024
tippfehlr
pushed a commit
to tippfehlr/avr-hal
that referenced
this pull request
Mar 24, 2024
blatantly taken from rust-embedded/cortex-m#504 Co-Authored-By: Alex Martens <[email protected]>
tippfehlr
pushed a commit
to tippfehlr/avr-hal
that referenced
this pull request
Mar 24, 2024
This is a follow-up to commit 403cf3b / PR Rahix#492, based on a review comment by @jannic on cortex-m (see PR [cortex-m#504]). [cortex-m#504]: rust-embedded/cortex-m#504 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to keep emebedded-hal 0.2 around for a bit while we're in the transition phase.
This also required a MSRV bump from 1.59.0 to 1.60.0 to align with
embedded-hal.