make Stim::write_* methods take &mut self instead of &self
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents people from overlapping non-atomic write operations on the same stimulus port when
working with generators (cooperative tasks).
For example, with this change the following code won't compile
``` rust
let stim = &mut ITM.stim[0];
let a = || {
loop {
// ..
for byte in b"Hello, world!".iter() {
while !stim.is_fifo_ready() { yield }
stim.write_u8(*byte);
}
// ..
}
};
let b = || {
loop {
// ..
for byte in b"The quick brown fox jumps over the lazy dog".iter() {
while !stim.is_fifo_ready() { yield }
stim.write_u8(*byte);
}
// ..
}
};
```
A possible fix for the above code is to use different stimulus ports in each task (generator).
|
@homunkulus r+ |
|
📌 Commit ee21e7d has been approved by |
japaric
pushed a commit
that referenced
this pull request
Jan 11, 2018
make `Stim::write_*` methods take `&mut self` instead of `&self`
this prevents people from overlapping non-atomic write operations on the same stimulus port when
working with generators (cooperative tasks).
For example, with this change the following code won't compile
``` rust
let stim = &mut ITM.stim[0];
let a = || {
loop {
// ..
for byte in b"Hello, world!".iter() {
while !stim.is_fifo_ready() { yield }
stim.write_u8(*byte);
}
// ..
}
};
let b = || {
loop {
// ..
for byte in b"The quick brown fox jumps over the lazy dog".iter() {
while !stim.is_fifo_ready() { yield }
stim.write_u8(*byte);
}
// ..
}
};
```
A possible fix for the above code is to use different stimulus ports in each task (generator).
|
☀️ Test successful - status-travis |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
73: fix rebuild-if-changed path r=japaric a=japaric Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents people from overlapping non-atomic write operations on the same stimulus port when
working with generators (cooperative tasks).
For example, with this change the following code won't compile
A possible fix for the above code is to use different stimulus ports in each task (generator).