Add SEV assembly instruction #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @Nemo157! bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 12, 2018
86: Add SEV assembly instruction r=japaric a=Nemo157 Co-authored-by: Wim Looman <[email protected]>
Build succeeded |
adamgreig
added a commit
that referenced
this pull request
Jan 12, 2022
Previously .data's LMA was specified by a computated address instead of placing it into FLASH explicitly, which means FLASH overflows caused by .data would not be detected by the linker. Fixes #86.
adamgreig
added a commit
that referenced
this pull request
Jan 12, 2022
87: Update linker script to put .data into FLASH r=japaric a=adamgreig This is the updated linker script and test from #86. Sadly it looks like LLD does not use the `ALIGN(4)` in the `.data` section header to align the LMA (unlike gcc), so we still need the `. = ALIGN(4)` at the end of `.rodata` to ensure LMA alignment. I've added a failing example which the ci script ensures fails when `.data` causes overflow. It just checks for non-zero return from cargo rather than specifically grepping for the linker error messages about `.data` overflowing; since we only have the one failing example I could remove the loop and just specifically check it and grep for the relevant error from gcc and lld if people think that would be better. Co-authored-by: Adam Greig <[email protected]> Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.