Change missing_docs from deny to warn. #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eldruin (rust-highfive has picked a reviewer for you, use r? to override) |
It is annoying to get hard errors while developing, it prevents testing things out without documenting them because it fails the build. This changes it to warn, which has the same effect in CI (because it already has `RUSTFLAGS: '--deny warnings'`), but still allows buildilng.
Dirbaio
force-pushed
the
warn-missing-docs
branch
from
462413d to
df73bb3
Compare
eldruin
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is annoying to get hard errors while developing, it prevents testing things out
without documenting them because it fails the build.
This changes it to warn, which has the same effect in CI (because it already has
RUSTFLAGS: '--deny warnings'),but still allows buildilng.