Change type of $lty argument to ty
#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ident` is not sufficient, as it won't allow something like `::module::Type`.
|
Thanks, @hannobraun. @homunkulus r+ |
|
📌 Commit b78b352 has been approved by |
|
💔 Test failed - status-appveyor |
|
I'm a bit confused by those AppVeyor failures. It's not obvious to me what causes those failures, as even the successful jobs are riddled with error messages. Seems unrelated to this pull request, though. Any idea what's going on, @japaric? |
japaric
pushed a commit
that referenced
this pull request
Oct 7, 2017
Change type of `$lty` argument to `ty` `ident` is not sufficient, as it won't allow something like `::module::Type`.
japaric
pushed a commit
that referenced
this pull request
Oct 7, 2017
Change type of `$lty` argument to `ty` `ident` is not sufficient, as it won't allow something like `::module::Type`.
|
💔 Test failed - status-appveyor |
|
Appveyor cache problem should be fixed in #152. @homunkulus retry |
japaric
pushed a commit
that referenced
this pull request
Oct 8, 2017
Change type of `$lty` argument to `ty` `ident` is not sufficient, as it won't allow something like `::module::Type`.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identis not sufficient, as it won't allow something like::module::Type.